@xmacex and @vicimity, thank you so much for your help finding these midi bugs and providing fixes. I should be able to review, test, and merge them sometime later today.
In regards to the midi_note_off delay issue reported by @vicimity, Iām thinking it might be nice to create a parameter setting for bypassing the delay when calling midi_note_off and Iāll add this to my preliminary roadmap in case I canāt get to it today.
[update] The code kindly provided by @xmacex to fix the midi output channel bugs mentioned above has been merged and a new release (v0.0.3-beta) has been created. The release also has two additional improvements for midi output, enabled by the following global variables set in lib/globals.lua:
-
midi_out_channel1 and midi_out_channel2 set the default midi out channels.
-
midi_out_envelope_override1 and midi_out_envelope_override2 set the delay time before calling midi_out_device:note_off, overriding the delay set by the envelopes by default. The code has these two new variables set to nil (so by default they are ignored).
@vicimity, this second set of global variables is meant to address the issue you encountered with your 0-coast.