@atomboyd you have some options
-
you can reset to some earlier place in the git history, maybe this hash:
9f9aff28d047b8754ba47cdaeb19a938ff6e5e7c
-
you can replace calls to filter_ to pre_filter_ in lua. e.g. pretty sure this would do it: back up first
cd ~
cp -R dust/ dust-backup/
cd dust
find . -type f -name "*.lua" | xargs sed -i 's/filter_/pre_filter_/g'
danger is other stuff that uses the string filter_. maybe lots. for a “dry run” remove -i and pipe sed to less
- add wrappers in the softcut module. or wait for me or brian to do it. (its a little ugly, but i guess it’s better than breakage, so, ehh, i’ll just do that right now.)
update: @atomboyd i pushed a branch with the backwards-compatibility wrapper and opened a PR. not totally convinced this is an awesome idea in the long run, versus just updating scripts (after we release a new version.)
if you want to try it, you can pull it from my fork
cd ~/norns
git remote add catfact https://github.com/catfact/norns.git
git fetch --all
git checkout catfact/softcut-pre-filter-wrap
./waf clean && ./waf
the last command not because it is necessary for this particular change, but always a good idea to rebuild when you pull down changes in norns repo.
meta question: seems like our git workflow could use a dev branch, strictly for API-breaking changes. i know this is controversial. any thoughts? our branch / tag protocol is extremely minimal right now.