This is indeed well thought through, and much more efficient at high current than a linear regulator (“clean” but inefficient) and far cleaner than a switchmode (“dirty” but highly efficient). Transformers are really fantastic when you spec them properly, with concern for core saturation and the like.
The concern about ground separation is good, although to be honest with the TS jacks you’re probably going to get ground on the analogue side connected right across to the digital again (or back to the rack power rails) through other modules, so I’m not entirely sure that that’s buying you a whole lot there, but from the “our module shouldn’t inject more noise itself” perspective, it’s spot on.