#185

do you mean shadow scripts? they were never implemented.

1 Like
#186

Ah. Well, that there answers my question! Thanks! With a L function, I’m sure I’ll always have a line of space to have them around.

Thanks!

#187

Looks like the $ in the new op names is interfering with LaTeX, which uses that symbol to start or end an in-line math section. I can take a look if you didn’t already.

1 Like
#188

that would be great! i thought it might have something to do with that and checked what the doc for $ looked like and didn’t see any additional formatting there.

1 Like
#189

@desolationjones have your ops found their way into the consolidated beta yet? No pressure or anything but I also don’t want you to think there’s no interest. I’m eager to try these out, preferably alongside the binary and hex entry ops.

#190

They have not! I had to RMA my CPU so the compy has been sitting idle. But the new CPU is working well and I hope to make time soon for this pull request. I am also eager to try the hex entry mode :smiley:

1 Like
#191

Seems the docs are building again :slight_smile: Thanks for the fix, you know who you are (but I don’t)!!!

1 Like
#192

that was generous help from @jngpng - super thankful as it saved me a lot of time! :black_heart:

2 Likes
#193

Then I’ll say thanks @jngpng :+1::+1::+1:

2 Likes
#194

My changes are in: QT.B, QT.S, QT.CS, DEL.B (my favorite), VN, and BTOG (bonus OP!). I can confirm they are all quite fun with the B and X numbers. DELAY_SIZE is turned up to 64 and seems quite stable so far in my testing.

@scanner_darkly I’m noticing that the X and B numbers do not allow converting to a negative number. E.g. X caps at X7FFF. Is that intentional or a limitation of the input parser?

EDIT: To clarify, you can put in larger numbers but it will not display a result greater than 32767.

EDITEDIT: Ok I can see this is a limitation of what we are passing to the strtol() function. I will hold further comment until I grok your implementation.

1 Like
#195

yeah that’s a bug. i’ll take a look.

#196

One solution could be to wrap val instead of capping at INT16_MAX. The consequence would be that a user could input 32768 and receive -32768 instead. For my own tastes I’d rather have no guardrails but I can see that tripping up new users.

The ADD and SUB OPs already wrap, and there are purpose-made MAX, MIN, and LIM OPs for limiting output ranges.

#197

What is BTOG? And 20 characters.

#198

BTOG x y "toggle bit y in value x"
So it flips the specified bit!
Very useful for things like X BTOG X RND 15 for flipping a single random bit of a gate pattern.

4 Likes
#199

fixed in this PR (also ran clang-format on files changed in your PR): https://github.com/monome/teletype/pull/226

2 Likes
#200

Awesome additions! Nicely done!

Was playing with DEL.B last night, and whilst it is awesome, I found the way it interacts with the B numbers a bit weird. It’s reading the pattern starting from LSB right? So when you use B you kinda have to write your pattern backwards? Maybe I was misunderstanding how B works when you don’t write out the full 16 bits.

1 Like
#201

Yes, you have it correct. So DEL.B M B1011: TR.P 1 would go “ping! ping! … ping!”

You don’t have to write out all 16 bits.

1 Like
#202

I guess the slightly weird UX is to do with the convention on writing binary numbers then, with LSB appearing last. Might it make sense for B to go against the convention and write the LSB first? IMO, that would make more sense for using it with both DEL.B and QT.B which both kind assume a left-to-right organisation (steps in the DEL case, keys in the QT case). What do you think @scanner_darkly?

1 Like
#203

I agree that the input is cumbersome if you are thinking of the lowest bits first while the cursor scrolls the “wrong way”, but the convention is firmly established. I think it is fair to compare it with the digits of a base-10 number. The smallest digit is always on the right, whether it is the “3” in “23” or the “0” in “B1110”.

Maybe we just need an input mode that scrolls the cursor backwards while inserting new characters :stuck_out_tongue:

#204

i would say that it’s better to change how DEL.B reads a number - since this would limit the non standard convention to this specific op (where it feels more natural), rather than applying it to how binary numbers are defined in general, which would go against the standard convention.

is there any concern about changing DEL.B to start with MSB instead?