I never even thought of this, despite its obviousness. I had planned to whip together a build once I get docs and formatting done, call it the release, tag the code and open the PR, but now I can see that this might be overstepping.
I’m not sure if @tehn, @cmcavoy, or yourself would have enough time in the next while to review some ~2700 lines of changes in any meaningful sense, so I have to presume that my PR will be accepted carte blanche for all intents and purposes.
The proof is in the pudding, IMO: the firmware builds and functions without known bugs. As a developer I know how much this statement reeks of hubris, but it’s a perspective that might be the most appropriate for this codebase, its developers, and the time they have to dedicate to the task.
Given some of the bugs I’ve found (did you know that there’s a blindingly-obvious buffer overflow in the USB code?), I can’t see stringency being applied to my PR at a granularity that exceeds that which has been applied already. (Scent: arrogant.)
Additionally, I’ve openly vetted all relevant design decisions with @tehn to prevent him from having to suss them out from the code and analyze them.
But, you know, I never asked @tehn about the release at all. I just picked the day that I would be done with 2.1 and called it. I guess that was pretty rude in retrospect. I struggle to strike a balance between incessant and presumptive and this time I missed. Sorry!
Anyhow, this is off-topic for this thread. I’ll engage the rest of this discussion in PM.