(Teletype) Firmware build troubles with 2.2 (Fixed!)

[sliderule]

I guess that wasn’t it. After checking out master and applying that change, I get the same behaviour again.

I’ll start commenting again and see what I find.

[sliderule]

Try changing it to:

    else if (show_welcome_message) {
        strcpy(s, TELETYPE_VERSION ": ");
        // strcat(s, git_version);
        show_welcome_message = false;
    }

Yup, it was this, after all. Don’t know why the build didn’t work the first time I commented it out.

The git version now includes the tag, I see. I’ll fix up this bug (bigger buffer, strncat), but we should prevent the gitversion from including the tag or else we won’t be able to see the build number.

[sam]

It includes the tag so that it picks up the version automatically too. Most tags are quite short, e.g. v2.1.1.

Just changing to strncat should be enough.

[sliderule]

But then there will be duplicate information in tagged builds, e.g.:

TELETYPE 2.2.0: v2.2.0-DEADBEE

If we’re including TELETYPE_VERSION, why would we need tags?

[sam]

Ah sorry. I’m getting confused, I thought we’d already merged this PR:

programatically grab version for docs and live mode

But we haven’t yet. I might get round to it next week…

What’s really funny is that I suspected those lines because I thought that they had changed recently, but they haven’t for 7 months!

[sliderule]

Changed my code to reflect that change. Thanks for finding this bug for me! Working with a lot of code at once makes my eyes glaze over sometimes.