Teletype Firmware i2c Debugging

sam · 2017-04-16T16:30:24.150Z

That was an easier fix than anticipated!

tehn · 2017-04-16T16:35:17.565Z

trickyflemming:

EDIT: Pretty instant crash the moment I plugged a timing signal into Script 1.

what’s your exact TT script setup so i can try to replicate this?

trickyflemming · 2017-04-16T16:39:21.785Z

I Script:
M.ACT 1
M 50

M Script:
TO.TR.TOG 1
TR.TOG 1

Scripts 1-8 are empty.

You can do TR.TOG 5 with an Ansible connected if you don’t have a TXo… pretty much any ii message will work. You could remove the TR.TOG 1 and it should still crash. I had it in the latest script because I couldn’t figure out why the M speed wasn’t updating and wanted to make sure that the TT was toggling at the same rate.

The above script runs fine on its own. Plug a fast-ish clock signal into Script trigger 1 and it should crash within 10 minutes.

EDIT: I’m using 4ms Row Power. I’ve tested it on both the White 30 and Black 40 variations. I currently have only the Teletype, Just Friends (not connected to ii), and TX modules on the bus, so I don’t believe it’s power related. I just thought I should list that here.

Edenmononym · 2017-04-16T22:10:12.408Z

EDIT: for some reason I only seen 2 original posts and made a reply… just in case it helps I will leave it here lol.

Hoping this helps.

Have you by chance used a meter to check for noise on the 5v rail and/or other power rails?

Whenever repairing someones module etc… it seems that micro controlled modules (AVR etc…) seem to get complicated if more modules are starving that area.

First steps for me would be to unplug and test just the teletype by itself and then with another module. Then start adding modules one at a time (maybe another module is causing noise?)…

The other possibility might rely on grounding capacity. ( There was a BEMI 291e that wigged out from an encoder that loved to ground itself with the metal panel - causing 5v rail noise , which is the i2c line - and the front panel sent audio signals into other module (261e) outputs…crazy stuff and funny fix)

Hoping this helps.

sam · 2017-04-17T07:44:36.577Z

Good news everyone!

I’ve recreated the bug with just a Teletype and an Ansbile (no II bus board) and using Pamala’s Workout as the trigger source

sam · 2017-04-17T09:26:33.839Z

@trickyflemming can you try this firmware please

teletype-i2c-fix-dd2070a-dirty.zip (104.0 KB)

sam · 2017-04-17T12:35:13.639Z

I’m trying to simplify the II transmission code on the Teletype.

At the moment there are 3 different ways to send an message over i2c. tele_ii, tele_ii_tx and tele_ii_tx_now.

tele_ii_tx and tele_ii_tx_now are identical, I think tele_ii_tx used to use the event queue and the i2c buffer. I’m going to delete tele_ii_tx_now as well as the i2c buffer code.

tele_ii is the original II sending function designed for use with the trilogy modules. It posts an event to the event queue which is then ultimately sent using the same i2c_master_tx function. I think it’s redundant to use the event queue to send II messages like this as we’re now moving to a situation where all code that sends i2c is run from the event queue already.

My plan is to update the one instance where tele_ii is used to instead use tele_ii_tx.

@tehn is this the correct way to send messages to Trilogy modules?

void op_simple_i2c(const void *data, scene_state_t *ss, 
                   exec_state_t *es, command_state_t *cs) {
    int16_t message = (intptr_t)data;
    int16_t value = cs_pop(cs);

    uint8_t address = message & 0xF0;
    uint8_t message_type = message & 0xFF;

    uint8_t buffer[3] = { message_type, value >> 8, value & 0xFF };

    tele_ii_tx(address, buffer, 3);
}

where data will be a constant from ii.h, e.g.

#define WW_PRESET 		0x11
#define WW_POS			0x12
#define WW_SYNC			0x13

My reading of a constant such as WW_PRESET, is that the first 4 bits define the address, but the entire value is the message. Only for Trilogy modules though. Right?

I should be able to test it by using the simulator to print the messages sent.

tehn · 2017-04-17T14:57:42.026Z

yes, your deconstruction of the trilogy-only simple ii message is correct.

and yes, there’s a lot of debugging leftovers still in there-- the old test i2c message queue, the tx vs tx_now, etc. what a mess.

i’ll try to reproduce the bug now also with that test built you posted.

tehn · 2017-04-17T15:00:32.707Z

Edenmononym:

Have you by chance used a meter to check for noise on the 5v rail and/or other power rails?

TT makes its own 5v, off the 12v rail

sam · 2017-04-17T15:35:08.546Z

tehn:

i’ll try to reproduce the bug now also with that test built you posted.

The main change was to move the tele_tick call and the metro script call into the event loop (the timers now only generate events), as you suggested earlier.

I’ve run it for a while with the following results (each of which has taken > 30 mins to appear).

Keyboard stopped working, front button and knob carried on. Metro kept running
Came back from the shops to find that the metro had stopped on it’s own, even though the teletype thought it was still running, restarted it.
An actual crash. Must have taken 2 hours though.

There have been a few other glitches, UI ones, and on occasion a different Ansible gate would fire.

My metro was set to 10, the fastest allowed. The only script set was M with TR.P 5 in it. I manually set the metro time. Pamela’s Workout was outputting triggers at 1/64 at 104 BPM into input 1.

IMO, the device is a lot less likely to crash with the changes. But it does get unhappy and a bit unpredictable.

tehn · 2017-04-17T16:09:00.100Z

i’ve been running for an hour, 10ms metro with MP clock-out driving TR 1 (seems around 25ms, visually)

haven’t seen any issues yet.

i was considering a method to thin out the event queue-- one approach with TR inputs is to have a status register. set the bit of a TR that’s been triggered, and create a new event only if the status register was previously empty. the event processor then runs scripts based on the status register and clears it upon completion (this would need to be interrupt protected). rationalization being, if TRs are firing faster than are getting processed in the event loop there’s a natural limiting as to not overflow the event queue.

sam · 2017-04-17T16:44:05.632Z

Seems a little hackish maybe? We’d have to place teletype specific logic into the general purpose events logic.

Alternative idea. Add time stamps to events when they are posted. (Need to be wary of timer overflows though.) Downstream event handlers can use this information as they see fit. The trigger event handler could check and only allow a script to run if it’s been 10ms since that script was last triggered.

It does’t reduce the number of events, but it does help process them quicker when they are coming in too fast.

Could also be used to implement a BPM calculation on each trigger input (useful for clock multipliers) in downstream code rather than having to do it in libavr32.

Another idea. Multiple event queues with different properties. E.g. a UI queue that’s not time critical but where it’s important that events aren’t dropped (so that we can guarantee the state of the system). And a ‘musical’ queue for things that want to be done quickly, but where we will liberally drop events when the load gets too high.

Or as @scanner_darkly suggests, let the user know that the event queue had to drop events and gently advise them that they should reboot (due to non-determine system state) and try to ease back the load.

Back to i2c, I’ve modified the i2c_* functions in libavr32 to return the status. In the Teletype firmware I’m printing that out to serial when it’s non-zero. I think that’s probably worth leaving in. It’s also possible we could try to feed that info back to users too. The UI code has been split up a lot so it’s hopefully not too hard to do. We could also add a i2c tx icon to the activity bar that lights up for a second or so whenever there is an i2c transmission.

bpcmusic · 2017-04-17T17:41:52.735Z

Since the conversation has turned to timers and interrupts, I figured it was appropriate to share this observation that I made the other day around the accuracy of M timing on the Teletype. Perhaps this is something that can be addressed in the midst of everything else.

When comparing the Teletype’s M timer to the the independent TR metronomes on the TXo, I noticed that they would very quickly fall out of sync with each other and phase. I didn’t expect perfect sync - but the rapid onset of phasing suggested that one or the other was running at a different rate. Curious, I hooked up both to my scope. I set up identical scenarios on each device for a single trigger output: 25ms trigger pulses 500ms apart.

Looking at the trigger outputs side by side, the Teletype seems to be running a hair fast.

Teletype is Blue; TXo is Red.

m_analysis.png790×205 2.85 KB

I haven’t poked around in the TT’s code to figure out why - at a glance everything looked cool. I filed it away on my list - but figured I’d share the observation now since @sam is looking at that area of the code.

Thanks to everyone for all of there efforts on the TT and i2c platform. I’m feeling pangs of guilt that I’m so wrapped up in soldering expanders that I haven’t had much time to devote to the investigation. Hopefully you will forgive me when I finally ship the things.

sam · 2017-04-17T18:10:50.433Z

Two things have changed that will make a difference to the M code.

The display refresh was taken out of the timer callback. (This will improve metro jitter.)
The metro code is no longer executed in the timer callback. (This will worsen metro jitter.)

Might be worth testing it again with the firmware posted in this thread, or once 2.0 beta 4 comes out. In particular I’d interested to know if it’s consistently slow, or if it’s jittery. Can your scope measure that?

tehn · 2017-04-17T20:57:58.936Z

ok-- finally got a “crash” after about 6 hours

not a hard crash, however.

lost USB keyboard connectivity. replug fixed.
METRO script just stopped responding. M.ACT 0 and then M.ACT 1 resumed it.

well, at least the errors are different now

sam · 2017-04-17T21:12:58.942Z

Same bugs as me then. Very interesting. They might have nothing to do with i2c though…

If I get a chance tomorrow I’ll set the same experiment up without any i2c, just pulsing a built in output.

trickyflemming · 2017-04-17T21:39:01.897Z

Updated and testing now. Thanks for pushing out a test firmware so quickly! I’ll report back if I get a crash. 30 minutes has been my threshold for calling it stable. If I make it past that, do you want me to run it until I experience the same Metro and keyboard bugs that you and @tehn are experiencing?

tehn · 2017-04-17T21:49:32.289Z

ok, i’m running the same test without i2c now.

trickyflemming · 2017-04-17T22:51:20.453Z

1 hour 15 minutes in: no crash yet. This is great progress
I’ll report back when the Metro or keyboard bugs manifest themselves.

trickyflemming · 2017-04-18T00:06:36.386Z

2.5 hours in. No keyboard or metro issues yet.