#78

Oooooh: caps lock is great idea for screen toggle.

#79

I would have modified each variables OP to stop using the voodoo peek / poke code I wrote1 and use a normal function with the added “variable updated” function call. But your solution with shadowed variables is better.

How about losing the magic ordering required to make vp work and instead:

int16_insert_correct_no_of_stars vp[8] = { &scene_state.variables.a, &scene_state.variables.b, .... };

(and at least one const, at least.)

Oh boy, I really dislike C. Alternatively, add a severe warning in state.h about changing the order of the first 8 members.

1 I did feel very chuffed with myself when I figured out how to do that in C.

#80

Well, it adds a dereference per, and really isn’t necessary. I wouldn’t exactly call struct ordering a “dark corner” of C, especially considering that this code is not expected to be portable.

I’ll add copious comments about the struct ordering. The only things that need to stay in order are those 8 variables, so it’ll be easy.

1 Like
#81

On all my computers I have my caps lock behave as a control key.

Every time I hit it by accident and have the display changes out on me, I will curse both your names :stuck_out_tongue:

(but don’t mind me, I can easily change it in code for my own build, so if everyone else is happy, go for it)

All of C is a “dark corner” as far as I am concerned.

I think I need to find a drink… I’m in some sort of weird fruity mood this evening. Not enough sleep last night…

2 Likes
#82

With my newfound rebase powers, I present to you: all the requested changes as a single commit! :slight_smile:

5 Likes
#83

For anyone to try: teletype.hex (354.2 KB)

(Teletype) 2.2 Release Status
#84

sorry for the vagueness. i was endorsing the left side of the final diagram but i am also fine with no lines, or adding them on popular demand.

also, why not have it just always be on? why toggle if there is nothing else there otherwise?

love the highlight on update idea. i don’t think it breaks gestalt, just builds upon

2 Likes
#85

Before I start digging through code, is there a way that I can poke the brightness of a set of pixels instead of redrawing the text?

#86

Screen burn-in, unless something else is done about that? :slight_smile:

#87

New build with dotted line on right side of columns.

teletype.hex (354.3 KB)

1 Like
#88

Another new build with auto-dimming values.

teletype.hex (354.7 KB)

4 Likes
#89

Wil it be possible to switch the auto-dimming off?

I see that people might find the surplus information useful but I am afraid it could be a little tiresome too for my eyes. Especially when it is a constant change as in the video.

:eyes::boom:

EDIT: I wonder if it does look a bit de-centered with the dotted lines on the right?

#90

It’s an open design option. If it does get included, there will likely be an op to turn it on/off.

I agree that it looks off. Centering the header might help?

#91

In case it actually is not off with the added lines an additional dotted line on the left might help. Centering the headers might make it look more off I am afraid.

1 Like
#92

I don’t think we should have an OP for that. We don’t have any OPs for configuring the UI, and I don’t think we should start.

Either we include it for everyone, or don’t.

Looking at the video, I’m not sure it adds enough. I guess our eyes are tuned to detect motion better then they are to detect changes in brightness.

Also, I think we’d have to change your implementation if we ‘flash’ the values. I would expect repeated calls of X 0 to flash the value even if the number doesn’t change.

(and if it does get dropped, sorry for the wild goose chase!)

2 Likes
#93

Yup.
I agree: seeing the brightness changes makes me less excited about this idea. It was definitely a good idea to try it though!

2 Likes
#94

Thinking about it some more…

I actually really like the design in first video you posted, no dotted lines. It’s simple and unfussy

5 Likes
#95

I think I have come to this decision as well. The “no lines” way just looks cleaner.

3 Likes
#96

agreed that the dotted line adds an unnecessary visual division, as that division already exists with the character alignment (which is great)

i could go either way on the dimming-- it seems not entirely necessary given the matrix isn’t a massive size

most of all, @sliderule: super impressed seeing these features so quickly executed!

5 Likes
#97

Alright, I’ll roll back the line and the dimming.

How do people feel about the display centering? I agree with @Leverkusen that it feels off. It pulls right and up to my eye.