#22

in main.c

w is a variable of whale_set type, and whale_set has a property whale_pattern wp[16] so w.wp is defined here:

	u8 loop_start, loop_end, loop_len, loop_dir;
	u16 step_choice;
	u8 cv_mode[2];
	u8 tr_mode;
	step_modes step_mode;
	u8 steps[16];
	u8 step_probs[16];
	u16 cv_values[16];
	u16 cv_steps[2][16];
	u16 cv_curves[2][16];
	u8 cv_probs[2][16];
} whale_pattern;```
1 Like
#23

Ok. Found it. Forgot this code is structure based, not class based. Readjusting…

#24

I was wondering if anyone’s made any progress on this? I was going to have a go but didn’t want to duplicate efforts.

1 Like
#25

No I’ve been too busy to start work on this yet. I don’t even have a dev environment setup yet for this, so it might be a couple of weeks before I’d have a Pull Request. If you’d like to take a stab at this please go ahead, I don’t think any work will be duplicated.

#26

I’ve not got the dev environment setup either, and won’t get to that until later in the week. I’ve got a first pass at the changes made. I’ll hold off on any II changes until I’ve had a chance to ensure that the changes made thus far build and work. If anyone with a build env wants the changes I’ve made (caveat emptor :wink: ) just drop me a message.

2 Likes
#27

OK, so I was bored. Toolchain built and so is the whitewhale.hex. However, given that I have a gig on Saturday, I’m going to have to hold off on testing until next week.

Has anyone else had issues with the toolchain instructions? The make install-dfu fails:

Duncans-MacBook-Air:avr32-toolchain duncan$ PREFIX=pwd/avr32-tools make install-dfu
[ -d downloads ] || mkdir downloads ;
cd downloads && curl -LO http://surfnet.dl.sourceforge.net/project/dfu-programmer/dfu-programmer/0.5.4/dfu-programmer-0.5.4.tar.gz
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:–:-- 0:01:15 --:–:-- 0curl: (7) Failed to connect to 2001:620:0:1b::21: No route to host

I think the source has moved?

#28

Thinking about for a moment, I guess I don’t need to bother building this.

#29

Question regarding expected behaviour: if in ping-pong mode, we switch to a different mode, say Drunk, when switching back to ping-pong, in which direction would you expect the sequence to continue? In the direction prior to the switch to Drunk, or Forward regardless of previous sense and regardless of the second mode picked?

#30

I would expect going forward again would be the default behavior. But I’m a bit weird.

#31

That was my expectation, but wanted to see if others agree!

#32

I should be able to get around to testing this tonight. @tehn is there any chance of me bricking the WW if I’ve messed up the code changes?

#33

Yea I think always starting in the forward position makes sense to me

#34

Works!

Instagram video to prove the point!

I’ve not tested the pattern switching or series mode yet.

2 Likes
#35

Oh man that’s exciting! If you open up a PR I’ll gladly do some code review

#36

I’ll have to figure out how to do that first!

There are definitely one or two bugs to be sorted. Deferred pattern change never happens, and in series it switches at the end of a run through forward.

#37

Fixed the deferred pattern change. In series mode there’s a double step, which has me stumped.

#38

And fixed that too :slight_smile: If someone can help me figure out how to land this, or would like the patch, drop me a message

1 Like
#39

What git client are you using, if any? You’ll need to create a fork of the mod repo and then submit a pull request.

#40

Command line all the way so far. I’ve made a local clone, and developed on a branch on that. From what I can tell on github, I don’t have the necessary permissions to create a branch on the main repo, which seems to be required to create a pull request there.

But as I’ve said, I’m a git newbie, more familiar with svn/hg.

#41

Right. You can’t submit a pull request directly against the repo but you can if you create your own fork.

https://help.github.com/articles/creating-a-pull-request-from-a-fork/

2 Likes