#31

That was my expectation, but wanted to see if others agree!

#32

I should be able to get around to testing this tonight. @tehn is there any chance of me bricking the WW if Iā€™ve messed up the code changes?

#33

Yea I think always starting in the forward position makes sense to me

#34

Works!

Instagram video to prove the point!

Iā€™ve not tested the pattern switching or series mode yet.

2 Likes
#35

Oh man thatā€™s exciting! If you open up a PR Iā€™ll gladly do some code review

#36

Iā€™ll have to figure out how to do that first!

There are definitely one or two bugs to be sorted. Deferred pattern change never happens, and in series it switches at the end of a run through forward.

#37

Fixed the deferred pattern change. In series mode thereā€™s a double step, which has me stumped.

#38

And fixed that too :slight_smile: If someone can help me figure out how to land this, or would like the patch, drop me a message

1 Like
#39

What git client are you using, if any? Youā€™ll need to create a fork of the mod repo and then submit a pull request.

#40

Command line all the way so far. Iā€™ve made a local clone, and developed on a branch on that. From what I can tell on github, I donā€™t have the necessary permissions to create a branch on the main repo, which seems to be required to create a pull request there.

But as Iā€™ve said, Iā€™m a git newbie, more familiar with svn/hg.

#41

Right. You canā€™t submit a pull request directly against the repo but you can if you create your own fork.

https://help.github.com/articles/creating-a-pull-request-from-a-fork/

2 Likes
#42

OK, gottit. Iā€™ll do that so.

#43

Pull request made, but I suspect it wonā€™t be landed. After I made the request it occurred to me that it might have issues with the smaller grids. Thereā€™s a ā€œfixmeā€ in the code that Iā€™d like to get clarification on before i attempt to address. As this will likely mean dropping one of the modes for the 8x8 grid shout now if you have a preference for one of the pingpong modes (repeating the end points, vs non-repeating).

#44

Could you link to the PR? I donā€™t see it when looking at the main Monome repository.

Isnā€™t this only 6 playback modes now? Why isnā€™t there room on the 8x8 grid?

If I had to chose, personally Iā€™d pick non-repeating, but I could see it both ways

#45

https://github.com/monome/whitewhale/pull/4

The issue is that the left three keys on that row are allocated to skip ahead, skip back and skip random, and 3+6>8 :wink:

1 Like
#46

Haha wow somehow I forgot those controls existed, I guess I donā€™t use them much (or at all)

#47

Ok, so back home and testing the refactor of the modes. Fixed that, but somehow introduced/exposed a bug in the process. I canā€™t figure out how exactly, Iā€™m triggering it, but somehow the active ā€œcursorā€ in row two, appears in the top row, travels right to left, and then WW hangs. Anyone know if thereā€™s some sort of error handling in the WW firmware? Iā€™ve not way of accessing the dbg messages.

#48

Seems to be with the skip step modes? Maybe? @tehn any chance this is what the FIXME comments are about?

#49

Finally got the soldering iron out and attached the I2C header. WW.PMODE works ok. Submitted a pull request with details of the known ā€œskip backā€ issue.

#50

With some help from @scanner_darkly the ā€œskip backā€ crash has been fixed. New pull request created. If anyone wants the binary in the meantime, let me know.

2 Likes