#41

Right. You can’t submit a pull request directly against the repo but you can if you create your own fork.

https://help.github.com/articles/creating-a-pull-request-from-a-fork/

2 Likes
#42

OK, gottit. I’ll do that so.

#43

Pull request made, but I suspect it won’t be landed. After I made the request it occurred to me that it might have issues with the smaller grids. There’s a “fixme” in the code that I’d like to get clarification on before i attempt to address. As this will likely mean dropping one of the modes for the 8x8 grid shout now if you have a preference for one of the pingpong modes (repeating the end points, vs non-repeating).

#44

Could you link to the PR? I don’t see it when looking at the main Monome repository.

Isn’t this only 6 playback modes now? Why isn’t there room on the 8x8 grid?

If I had to chose, personally I’d pick non-repeating, but I could see it both ways

#45

https://github.com/monome/whitewhale/pull/4

The issue is that the left three keys on that row are allocated to skip ahead, skip back and skip random, and 3+6>8 :wink:

1 Like
#46

Haha wow somehow I forgot those controls existed, I guess I don’t use them much (or at all)

#47

Ok, so back home and testing the refactor of the modes. Fixed that, but somehow introduced/exposed a bug in the process. I can’t figure out how exactly, I’m triggering it, but somehow the active “cursor” in row two, appears in the top row, travels right to left, and then WW hangs. Anyone know if there’s some sort of error handling in the WW firmware? I’ve not way of accessing the dbg messages.

#48

Seems to be with the skip step modes? Maybe? @tehn any chance this is what the FIXME comments are about?

#49

Finally got the soldering iron out and attached the I2C header. WW.PMODE works ok. Submitted a pull request with details of the known “skip back” issue.

#50

With some help from @scanner_darkly the “skip back” crash has been fixed. New pull request created. If anyone wants the binary in the meantime, let me know.

2 Likes